zielu / GitToolBox

GitToolBox IntelliJ plugin
GNU General Public License v3.0
604 stars 73 forks source link

[BUG] saved selected files in rollback menu #380

Closed IWareQ closed 1 year ago

IWareQ commented 2 years ago

Describe the bug The file is not saved when rolling back

To Reproduce Steps to reproduce the behavior:

  1. Select the files you want to rollback
  2. Click on the rollback button
  3. Look at how your sample files are not selected

Expected behavior Saving a selection of files

Plugin version 212.8.4

Kotlin: 213-1.6.10-release-923-IJ5744.223

IDE version IntelliJ IDEA 2021.3.1 (Ultimate Edition) Build #IU-213.6461.79, built on December 28, 2021

Screenshots image image

IWareQ commented 1 year ago

Please fix

zielu commented 1 year ago

Hi, from the description I don't understand what is wrong. Describe exactly which UI are you using for rollback (dialog or tool window) and why do you expect that after rollback files should be selected - afaik they disappear from UI

IWareQ commented 1 year ago

Hi, from the description I don't understand what is wrong. Describe exactly which UI are you using for rollback (dialog or tool window) and why do you expect that after rollback files should be selected - afaik they disappear from UI

https://user-images.githubusercontent.com/51165317/195332088-de16cfe8-424b-4f19-84ff-904fbc60774c.mp4

zielu commented 1 year ago

Can you check if it works as expected with my plugin disabled ? So far I cannot reproduce it.

IWareQ commented 1 year ago

Can you check if it works as expected with my plugin disabled ? So far I cannot reproduce it.

yes, it works

zielu commented 1 year ago

I managed to reproduce this and it is buggy too without my plugin installed - I tried Idea CE 2022.2.3. Best report this to Jetbrains.

What I noticed is that it happens with newly added files and in Rollback Changes dialog only the checkbox for last selected file is marked.