search

zielu / GitToolBox

GitToolBox IntelliJ plugin
GNU General Public License v3.0
604 stars 71 forks source link

[BUG] Inline Comment dislocation #425

Closed shilohooo closed 1 year ago

shilohooo commented 1 year ago

Describe the bug Inline Comment dislocation.

To Reproduce

  1. Open a git project via IntelliJ IDEA.
  2. Open a file.
  3. See the inline comment.

Expected behavior Inline comment are not misplaced.

Plugin version 212.10.1.

IDE version IntelliJ IDEA 2022.2.3 (Ultimate Edition) Build #IU-222.4345.14, built on October 5, 2022 Subscription is active until December 30, 2022. Runtime version: 17.0.4.1+7-b469.62 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 10 10.0 GC: G1 Young Generation, G1 Old Generation Memory: 3072M Cores: 8 Non-Bundled Plugins: one.util.ideaplugin.screenshoter (1.8) de.netnexus.camelcaseplugin (3.0.12) org.jetbrains.kotlin (222-1.7.21-release-272-IJ4167.29) com.alibaba.p3c.smartfox (2.1.1) zielu.gittoolbox (212.10.1) MavenRunHelper (4.23.222.2964.0) cn.yiiguxing.plugin.translate (3.3.5)

Kotlin: 222-1.7.21-release-272-IJ4167.29

Screenshots image.

zielu commented 1 year ago

Hi, I'll take a look - I did not test english and chinese combo.

shilohooo commented 1 year ago

Thanks

zielu commented 1 year ago

@shilohooo could you share your setting from here?

image

And maybe some test for which this is happening.

shilohooo commented 1 year ago

@zielu image

StevenCai457 commented 1 year ago

Same issue with chinese and english composed comment,previous version works fine.

zielu commented 1 year ago

@StevenCai1996 can you provide some sample and same settings page as original reporter? I tried to reproduce it but no luck so far.

StevenCai457 commented 1 year ago

@zielu gittoolboxRP2 gittoolboxRP1

https://github.com/StevenCai1996/gittoolbox213102Report.git You can pull this sample project to see inline blame. 212.8.8 [O] dif1

213.10.2 [X] dif2

zielu commented 1 year ago

@StevenCai1996 your are on Windows by any chance ?

StevenCai457 commented 1 year ago

@StevenCai1996 your are on Windows by any chance ?

Yes,Win 10 pro 64bit

shilohooo commented 1 year ago

After upgrading WebStorm to 2022.3 and GitToolBox to 213.10.2, the plug-in works fine.

The screenshot: image

and setting: image

shilohooo commented 1 year ago

The inline blame in IntelliJ IDEA v2022.2.4: image and my setting: image

Plug-in version is 213.10.2

shilohooo commented 1 year ago

Hope it can help you to reproduce the problem:)

zielu commented 1 year ago

2022.2 and Windows is the way to reproduce this - I found there is indeed difference in aligning text between plugin 212.8.8 and more recent code. Some Y coordinate adjustments were lost along the way...

zielu commented 1 year ago

Looks like old code is the best code :)

shilohooo commented 1 year ago

Can't agree more.

zielu commented 1 year ago

Done in 213.10.3