zielu / GitToolBox

GitToolBox IntelliJ plugin
GNU General Public License v3.0
604 stars 71 forks source link

[BUG] Gitmoji completion not working anymore in non-modal commit UI in 2022.3.1 #441

Closed maicol07 closed 1 year ago

maicol07 commented 1 year ago

Describe the bug

Gitmoji completion isn't working anymore in the non-modal commit UI in 2022.3.1 (The autocompletion popup doesn't appear). The commit dialog works fine.

To Reproduce
Steps to reproduce the behavior:

  1. Write a message in the non-modal commit UI
  2. Try to write a gitmoji name to test autocompletion
  3. See no popup is shown

Expected behavior

Autocompletion works.

Plugin version
213.10.5

IDE version

PhpStorm 2022.3.1
Build #PS-223.8214.64, built on December 22, 2022
Licensed to Maicol Battistini
Subscription is active until January 10, 2024.
For educational use only.
Runtime version: 17.0.5+1-b653.23 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Linux 5.15.79.1-microsoft-standard-wsl2
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 24
Registry:
    editor.focus.mode.color.light=d2d4d5
    ide.editor.tab.selection.animation=true
    debugger.new.tool.window.layout=true
    run.processes.with.pty=TRUE
    ide.experimental.ui=true
    ide.balloon.shadow.size=0
    editor.focus.mode.color.dark=d2d4d5

Non-Bundled Plugins:
    com.github.patou.gitmoji (1.11.1)
    com.github.lppedd.idea-conventional-commit (0.21.0)
    com.fwdekker.randomness (2.7.6)
    com.nasller.CodeGlancePro (1.5.9)
    com.obroom.plugin.smartsearch (2022.6.1)
    awesome.console (0.1337.12)
    com.renemaas.intellij.zipper (1.1.0)
    com.github.copilot (1.1.38.2229)
    org.intellij.plugins.postcss (223.7571.117)
    org.jetbrains.plugins.stylus (223.7571.203)
    com.khmelyuk.multirun (1.13)
    com.intellij.ideolog (203.0.30.0)
    String Manipulation (9.6.1)
    siosio.EmojiCommitLogViewer (1.0.5)
    com.shuzijun.markdown-editor (2.0.2)
    lermitage.intellij.extra.icons (2022.1.14)
    com.github.camork.fileExpander (2.1)
    hu.hawser.co-author-plugin (2.3)
    com.intellij.jira (4.3.0)
    com.github.shiraji.emoji (3.1.0)
    com.github.beansoft.iscratch (2022.3.0)
    GrepConsole (12.15.211.6693.1)
    pro.bashsupport (3.0.4.223)
    com.almightyalpaca.intellij.plugins.discord (1.11.0)
    com.virtuslab.git-machete (3.2.2)
    com.obroom.plugin.toolset (2022.12.1)
    com.github.jk1.ytplugin (2022.1.237)
    mdx.js (223.8214.16)
    org.sonarlint.idea (7.3.0.59206)
    de.sist.gitlab (2.13.2)
    com.mallowigi (82.0.0)
    zielu.gittoolbox (213.10.5)
    mobi.hsz.idea.gitignore (4.4.4)
    com.pixelperfect.gitlab-ci (2022.0.16)
    com.intellij.plugins.html.instantEditing (223.8214.16)
    com.kalessil.phpStorm.phpInspectionsEA (4.0.7.1)
    com.chrisrm.idea.MaterialThemeUI (8.4.1)
    com.funivan.idea.phpClean (2022.08.30)
    lv.midiana.misc.phpstorm-plugins.deep-keys (2022.08.03.001)
    ru.adelf.idea.dotenv (2022.3)
    nl.deschepers.laraveltinker (2.5.1)
    net.king2500.plugins.PhpAdvancedAutoComplete (1.1.0)
    de.espend.idea.php.toolbox (6.1.0)
    de.espend.idea.php.annotation (8.3.0)
    org.masamotod.idea.Drupal8NamespaceDetector (1.0)
    net.rentalhost.plugins.php.hammer (0.18.0)
    org.endpointdeps.EndpointDependencies (1.3)
    dev.nybroe.collector (0.4.0)
    com.laravel_idea.plugin (6.2.2.223)

Current Desktop: Undefined
maicol07 commented 1 year ago

Workaround waiting for an official fix: Switch to commit dialog and then switch again to commit tool window

zielu commented 1 year ago

Hi, this happened when you had non-modal dialog enabled as default and just installed the plugin? Reason I'm asking is that workaround somehow fixes the situation.

maicol07 commented 1 year ago

Yes, non-modal commit UI is enabled by default and then I've installed the plugin

zielu commented 1 year ago

Looks like some weird timing issue, I found alternative way of supporting completion that should not be affected by this

zielu commented 1 year ago

Done in 500.0.3+213