zielu / GitToolBox

GitToolBox IntelliJ plugin
GNU General Public License v3.0
605 stars 74 forks source link

[Feature] Make icon color more neutral #481

Closed tyrann0us closed 1 year ago

tyrann0us commented 1 year ago

Is your feature request related to a problem? Please describe. I've been using your plugin for a couple of weeks now, and it's really great; thanks for maintaining it!

One thing bothers me, though: The icon in the GitToolBox notifications is red. For many people, including me, red means error. Whenever GitToolBox does an auto fetch or similar, the notification overlay shows, and I instantly think something has failed. This is hardened by my brain turning the message "Auto fetch finished" into "Auto fetch failed" if it sees the red icon next to it.

Bildschirmfoto 2023-05-16 um 08 56 55

Describe the desired solution Use an icon with a more "neutral" color, like blue.

Describe the alternatives that you have considered Don't output the notification so "prominently" because everything's already in the "Notifications" tab/toolbar. But even there, the red icon causes me to think everything failed:

Bildschirmfoto 2023-05-16 um 10 27 33

Have fun finding the actual failure. 😉

Additional context PhpStorm 2023.1.1

zielu commented 1 year ago

Agreed, it looks confusing. I'll dial it down 🙂

zielu commented 1 year ago

For info notifications I will adopt same color as IDE info icon - should blend right in :)

image
zielu commented 1 year ago

Done in 500.0.9

tyrann0us commented 1 year ago

Hi @zielu, not sure if this is a problem on my side, but with 500.0.9+213, most icons are still in the old color:

Bildschirmfoto 2023-06-05 um 13 05 47

Note that I use the free version.

Thanks!

zielu commented 1 year ago

I'll take a look tonight

zielu commented 1 year ago

Done in 500.0.10 (this time for good :))

tyrann0us commented 1 year ago

I can confirm it works now. Thanks a ton! 🎉

Bildschirmfoto 2023-06-08 um 08 50 14