search

zielu / GitToolBox

GitToolBox IntelliJ plugin
GNU General Public License v3.0
605 stars 74 forks source link

[BUG] "File is too big for inline blame calculation" warning banner is shown even when inline blame is disabled #536

Closed PrOF-kk closed 7 months ago

PrOF-kk commented 7 months ago

Describe the bug The "File has 5,000 or more lines, inline blame calculation might be CPU intensive" warning banner is shown even when the feature is disabled

To Reproduce Steps to reproduce the behavior:

  1. Disable inline blame in Settings > Version Control > GitToolBox > "Blame" tab > uncheck "Show editor inline Blame"
  2. Open a very large file
  3. See warning banner anyway

Expected behavior Plugin shouldn't calculate inline blame at all if not enabled

Plugin version 500.1.11+222

IDE version PhpStorm 2023.3.4

zielu commented 7 months ago

Hi, it looks like I missed this code path. Large file notification can be triggered by two features:

  1. inline blame that you disabled
  2. status bar blame - GitToolBox > General > Show 'Blame' in status bar

As a workaround, until I fix this, you can disable second one too and restart it. Blame calculation should not be triggered anymore.

zielu commented 7 months ago

Done in 500.2.0