zifeo / whiz

Modern DAG/tasks runner for multi-platform monorepos with live reloading, env management, pipes, and more in a tabbed view.
https://metatype.dev/docs/reference/ecosystem?utm_source=github&utm_medium=about&utm_campaign=whiz
Mozilla Public License 2.0
19 stars 14 forks source link

Use glob_match instead of globset #24

Open zifeo opened 1 year ago

zifeo commented 1 year ago

https://github.com/devongovett/glob-match

abdiu34567 commented 11 months ago

Hello! 👋

I'm interested in working on this issue to replace globset with glob-match. I've taken a preliminary look at the codebase, and I believe I can tackle this. Before I dive in, I'd like to clarify a few points:

Reason for Switch: Can you provide a bit more context about why we're considering this switch? Are there any specific advantages of glob-match over globset that I should be aware of?

Backward Compatibility: Do we aim to ensure complete backward compatibility in behavior, or are slight deviations acceptable as long as the primary functionality remains consistent?

Existing Tests: Are there existing tests that cover the functionalities using globset? If yes, I'll ensure they all pass after the switch. If not, I'll aim to write tests to ensure the behavior is consistent.

Deprecation: Post the switch, do we intend to deprecate all globset functionalities immediately or will there be a transition phase?

Looking forward to your insights. Once I have a clearer picture, I'll start with the implementation.

zifeo commented 11 months ago

@abdiu34567 Thanks for asking for some details: