Closed pecuchet closed 4 years ago
Any chance this can be merged?
Hi, can you take a look at:
https://github.com/ziffmedia/nova-select-plus/pull/8
It looks like label
is only ever really used as the label for selectable values, so I think its prob best to just use that API, thoughts?
edit: this appears to be closer to your original suggestion in #6 perhaps?
Hi @ralphschindler, thanks for looking into it. The reason why I proposed the usingEditLabel
method, was because of this line in the Controller:
$query->where($field->label, 'LIKE', "%{$search}%");
I couldn't immediately find a solution for $field->label
when it is callable instead of a string. If it works with your suggestion, fine for me ;-)
Fixed in v1.0.5, thanks for the input and ideas!
Hello,
Much like
usingIndexLabel
andusingDetailLabel
, this allows to customize the label on the edit screen. For example:Fixes #6