ziflex / lecho

Zerolog wrapper for Echo framework 🍅
MIT License
97 stars 11 forks source link

fix-reqid: add multiple request id headers #29

Closed KaymeKaydex closed 7 months ago

KaymeKaydex commented 7 months ago

when working in a large architecture and project, sometimes from legacy services you can pin multiple headers for the request ID

for example: X-Req-ID or Req-ID

ziflex commented 7 months ago

Hey, thanks for your PR. But could you tell me why you don't use Enricher function for such cases?

KaymeKaydex commented 7 months ago

Hey, thanks for your PR. But could you tell me why you don't use Enricher function for such cases?

I didn’t think about it right away, but it can indeed be used in this case. But anyway, this functionality will be more convenient to read and use

ziflex commented 7 months ago

Maybe, but the problem is that it's a breaking change. If something can be achieved with existing functionality I do not see any need in introducing a breaking change to the library.