search

zifn / CS289_Coltrims_ML

repo for the final project of berkeley CS289
0 stars 1 forks source link

Clean up Analysis module #35

Open zifn opened 3 years ago

zifn commented 3 years ago

The Analysis module has several long functions that aren't properly documented and there are several hard coded values that should be turned into parameters that can be set in the config yaml file. Also the analysis module should be run on a small synthetic dataset as an integration test.

sajantanand commented 3 years ago

I think the "only_even_Ls" parameter could be tied to whether or not we convert to the molecular frame, but maybe I am getting this wrong.