zigalenarcic / mangl

An enhanced man page viewer for linux and BSD systems based on OpenGL and mandoc libraries
Other
38 stars 7 forks source link

Debian Packaging: Deprecated Encoding Key in mangl.desktop #20

Open montj2 opened 1 month ago

montj2 commented 1 month ago

Hello @zigalenarcic,

I'm James, and I'm currently working on packaging mangl (1.1.5-1) for inclusion in Debian (ITP #1075734). During the packaging process, a lintian warning was raised regarding the use of the Encoding key in the mangl.desktop file:

I: mangl: desktop-entry-contains-encoding-key Encoding [usr/share/applications/mangl.desktop:2]

According to the latest FreeDesktop.org Desktop Entry Specification (https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html), the Encoding key is deprecated. Since UTF-8 is now the standard encoding for desktop entries, this key can be safely removed.

I've attached a patch file (mangl.desktop.patch) that removes the Encoding key from the mangl.desktop file. Applying this patch will make the desktop entry compliant with the latest standards and help avoid lintian warnings during Debian packaging.

Please consider incorporating this change in a future release of mangl.

Thank you for your time and consideration, and for creating such a useful tool!

Best Regards,

James

Patch (mangl.desktop.patch):

--- mangl.desktop   (original)
+++ mangl.desktop   (modified)
@@ -1,2 +1,1 @@
 [Desktop Entry]
-Encoding=UTF-8
 Version=1.0
 Type=Application
 Terminal=False
 Name=Mangl
 Comment=An enhanced man page viewer
 Categories=Utility;Development;
 Exec=mangl
 Icon=/usr/share/icons/hicolor/scalable/apps/mangl.svg
zigalenarcic commented 1 month ago

Hi James!

Thanks for your work on Debian package. I applied the suggested patch. Please let me know if it is beneficial for you to prepare a release which includes this patch.

Again thanks for your work and contribution!

Kind regards, Ziga