devbox allows a device to be added twice

zigbeer / zigbee-shepherd

An open source ZigBee gateway solution with node.js.

MIT License

250 stars 89 forks source link

devbox allows a device to be added twice #39

Open RobinBol opened 6 years ago

RobinBol commented 6 years ago

Devbox seems to be using a generated (sequence) ID, this allows for multiple entries with the same ieee address. Wouldn't it be better to use the ieee address as an ID?

This isn't really an issue at the moment, I encountered it in an edge case where some event listeners were bound twice which resulted in duplicate entries for a single device in the devbox when pairing.

lolorc commented 6 years ago

different entries for a single device, hint might be "joinTime" that differs between duplicates.