search

zigdon / twirssi

An irssi script allowing the use of Twitter from within the IRC client.
http://twirssi.com
133 stars 26 forks source link

fix detection of multiple @mentions #12

Closed mmitch closed 13 years ago

mmitch commented 13 years ago

use //g for multiple matches take result from $_ because $1 will always contain the last match

the old code only found the first @mention - and seeing that there is a foreach loop, this does not seem to be intended

mmitch commented 13 years ago

why does the second commit already show up here, too? anyways, I don't have to open another pull request then :)

The second commit fixes a warning in debug mode that was displayed on every get_updates() when the follow_extra list is empty:

19:06 get_timeline(0= > ) started. username = @Twitter 19:06 Error during user_timeline() call: Aborted. 19:06 : $VAR1 = 'required arg \'id\' missing at ~/.irssi/scripts/twirssi.pl line 1319 19:06 : ';

mmitch commented 13 years ago

pull request has been merged