zigdon / twirssi

An irssi script allowing the use of Twitter from within the IRC client.
http://twirssi.com
133 stars 27 forks source link

Wanted: more meaningful error messages #57

Closed sjn closed 10 years ago

sjn commented 12 years ago

I get the following error all the time:

13:46 ERROR: Update encountered errors.  Aborted

This is useless for debugging or otherwise figuring out what I need to fix.

Can you add some more descriptive text to the error message? (e.g. push messages to an "errors" array and use this to create the final error message?)

rkitover commented 12 years ago

I keep getting this error too spamming my twitter window and I have no idea what's wrong.

tobbez commented 12 years ago

If you get this after upgrading from a very old version, try removing ~/.irssi/scripts/twirssi.json and reloading twirssi.

If that doesn't help, try also removing ~/.irssi/scripts/twirssi.oauth and reauthenticating to twitter.

Removing both solved the problem for me (but removing the latter file probably doesn't make a difference).

sjn commented 12 years ago

tobbez, thank you for the workaround, but that's not what this bug is about. :)

This bug is about the amount of meaning and understanding a user can get from reading a given error message. The solution to this problem would presumably include a rewording of that message, so that it either contains information on what actually went wrong (and ideally, an pointer on what one could try to fix that particular problem), or - if this isn't feasible, some instructions on how to find out what's actually happening (e.g. "Please turn on debug mode to get more information: /set twirssi_debug on")

tobbez commented 12 years ago

Seeing as this is the only search result that is at least somewhat related to the error message, I decided to write down that information so that it would be found by others searching for a solution.

I still agree that that there needs to be better error messages that communicate the nature of the error to the user.

rkitover commented 12 years ago

Thanks Torbjörn, that is what I ended up doing.

I talked to zigdon and Gedge on the foonetic #twirssi channel. Gedge quickly hacked in some some more verbosity into the error message, my new error message showed it was a problem with 'dm'. He told me I need to reauthorize twirssi, like you said. I deleted the files, reauthorized twirssi, and the problem was gone.

Gedge also promised to explain this in the new error message for other people experiencing this problem.

gedge commented 10 years ago

Can I close this, please?

sjn commented 10 years ago

Sure, close it.