zigdon / xkcd-Bucket

Bucket is the channel bot for #xkcd
http://wiki.xkcd.com/irc/Bucket
121 stars 31 forks source link

Accept a/an in more places (triggers) #109

Open dgw opened 7 years ago

dgw commented 7 years ago

Things like the fact can trigger Bucket to retrieve a factoid, but it's sometimes odd that a fact/an object cannot.

This is especially noticeable with features like what's x, where what's the factoid can trigger but what's a factoid can't. Sometimes the indefinite article is the correct way to construct the sentence, and the definite sounds completely wrong.

My list of things to implement is getting to be kind of a mile long, but I'd like to fix this at some point if there's no reason it shouldn't be supported. If indefinite articles were left out of Bucket's core for a reason, I'm happy to go the plugin route.

Note: I could have sworn there was an issue about this already, but ten minutes of trying various keywords in the issue search turned up nothing, open or closed. Shouldn't be a duplicate, then, but if it is… I fail hard. Harder than I just did hitting "Create issue" without closing this italic section first.