zigdon / xkcd-Bucket

Bucket is the channel bot for #xkcd
http://wiki.xkcd.com/irc/Bucket
121 stars 31 forks source link

Bucket infinitely follows alias loops in 'literal' #111

Open dgw opened 7 years ago

dgw commented 7 years ago

Bucket is smart about detecting alias loops if a factoid is simply triggered, but if asked for the 'literal' of a factoid that is part of an alias loop, the result is an infinite loop (and flooding the log channel with "Asked for the 'literal' of an alias, being smart and redirecting to 'target'").

Ideally, alias loops should be impossible to create. But at the very least, Bucket should apply the same loop-detection to 'literal' as to regular factoid lookups.