search

zigdon / xkcd-Bucket

Bucket is the channel bot for #xkcd
http://wiki.xkcd.com/irc/Bucket
121 stars 31 forks source link

Strip colon-terminated line prefix only if followed by space #79

Closed dgw closed 8 years ago

dgw commented 8 years ago

Alleviates some of #76, but only for keywords like "Re:Zero". Does not help for keywords like "Re: Zero".

This implements the main fix I suggested, but does not close the issue as it might yet be desired to fix this completely and allow triggers of the form Word: More Words.

As far as testing, this has been running in my production instance probably since mid-June. It's been so long that I forgot when I actually added it.

zigdon commented 8 years ago

I think this is the wrong fix - much more likely people type nick:something (when not using tab completion) than wanting to trigger a factoid that way.

dgw commented 8 years ago

That's fair. I'll work on an alternate solution and open a different PR.