search

ziglang / zig-bootstrap

take off every zig
368 stars 86 forks source link

Use cmake --build instead of makefiles #139

Closed kcbanner closed 1 year ago

kcbanner commented 1 year ago

The build script assumes that a makefile will exist after running cmake. In my case (MINGW64 / MSYS2 shell), Ninja was the default.

andrewrk commented 1 year ago

Perhaps instead the build script can be enhanced to support the native generator, without introducing any branching logic into the build script?

Perhaps something like cmake --build . --target INSTALL instead of invoking make separately.

kcbanner commented 1 year ago

Updated to use the default cmake generator. However, I ran into some build issues on mingw (https://github.com/ziglang/zig/issues/12703#issuecomment-1233130622), so I can't verify this is working yet.