search

ziglang / zig-mode

Zig mode for Emacs
GNU General Public License v3.0
163 stars 54 forks source link

Avoid use of regexp in rx macros #44

Closed joachimschmidt557 closed 3 years ago

joachimschmidt557 commented 3 years ago

This "solves" https://github.com/ziglang/zig-mode/issues/42 by avoiding the use of regexp and instead embedding the corresponding regular expressions.

larme commented 3 years ago

literal was not implemented until emacs 27. This pr alone won't fix backward compatibility problem.

joachimschmidt557 commented 3 years ago

@larme Oh yes, I forgot that. I'll create another PR for that. Thanks!

joachimschmidt557 commented 3 years ago

I will close this as this does not fully fix the issue of backwards compatibility. If there is an option to use rx macros without hacks, then this can be reopened.