search

ziglang / zig-mode

Zig mode for Emacs
GNU General Public License v3.0
163 stars 54 forks source link

Revert "Use rx macro and add more possibilities for type annotations" #45

Closed joachimschmidt557 closed 3 years ago

joachimschmidt557 commented 3 years ago

This reverts commit 859a4dc4b71c6556bd3fadf61e0239ae72360aa2.

Maybe switching to rx macros is not worth the trouble when regexp and literal don't work in emacs versions lower than 27.

agentultra commented 3 years ago

Can confirm zig-mode doesn't work on GNU Emacs 26.3 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.14) because of this.

I get File mode specification error: (error rx form ‘regexp’ requires args satisfying ‘stringp’)

AndreaOrru commented 3 years ago

Right. I didn't test it on Emacs 26, but I'll trust @agentultra on this. Merging.