search

ziglang / zig-mode

Zig mode for Emacs
GNU General Public License v3.0
163 stars 54 forks source link

Use read-only-mode instead of toggle-read-only #48

Closed noisegul closed 3 years ago

noisegul commented 3 years ago

toggle-read-only was declared obsolete in emacs 24.3

I also updated the recommended emacs version in the README. Let me know if this is desired or not.

The change fixes the related compiler warning:

In colorize-compilation-buffer:
zig-mode.el:448:4:Warning: ‘toggle-read-only’ is an obsolete function (as of
    24.3); use ‘read-only-mode’ instead.
zig-mode.el:449:31:Warning: ‘toggle-read-only’ is an obsolete function (as of
    24.3); use ‘read-only-mode’ instead.
noisegul commented 3 years ago

Made the deactivation and activation explicit, as suggested by @joachimschmidt557

justjosias commented 3 years ago

I noticed this problem when I installed zig-mode recently. Looking forward to the merge of this PR.

AndreaOrru commented 3 years ago

Looking good. Thanks! Sorry for the late review. Merging.

noisegul commented 3 years ago

No problem, thank you!