ziglang / zig-mode

Zig mode for Emacs
GNU General Public License v3.0
157 stars 54 forks source link

Use builtin `ansi-color-compilation-filter` on Emacs >= 28 #69

Closed erikarvstedt closed 2 years ago

erikarvstedt commented 2 years ago

Rationale: On Emacs >=28, the default way to enable ansi-colors in compilation buffers is to add the new builtin fn ansi-color-compilation-filter to compilation-filter-hook.

Previously, zig-mode forced users to add a custom colorizing fn (colorize-compilation-buffer). In case ansi-color-compilation-filter is already used, this would lead to the ansi-coloring being applied twice (no functional error because it's idempotent).

joachimschmidt557 commented 2 years ago

Thanks!