search

ziglang / zig-mode

Zig mode for Emacs
GNU General Public License v3.0
166 stars 55 forks source link

Replace obsolete function `point-at-eol` with equivalent. #81

Closed dpathakj closed 1 year ago

dpathakj commented 1 year ago

Emacs 29.1+ emits a warning when code using point-at-eol is compiled; see emacs/master commit b7e867. This is a trivial but safe change to get rid of that warning. point-at-eol seems to have been the same thing as line-end-position since 1999 (emacs/master commit 475fb2f). I've tested this briefly and the behavior of zig-end-of-defun does seem to be the same with this change.

dpathakj commented 1 year ago

The tests in ./run_tests.sh also pass (though note the second commit in this PR, which fixes a duplicate test that went from passing silently to failing with an error message at some point between emacs 27.1 and 29).

joachimschmidt557 commented 1 year ago

Thanks for the fix and the thorough compatibility investigation!