Closed csachs closed 1 year ago
Please split the pull request into several smaller ones so that your changes can be discussed and applied individually. At the moment I don't have the review bandwidth to look into it otherwise.
I'm happy to continue review here. I'm particularly interested in the removal of libarchive-c
dependency.
Interested also, currently builds seem to fail on latest macos
As far as I understand this has been merged already.
I'm happy to continue review here. I'm particularly interested in the removal of
libarchive-c
dependency.
Sorry for the delay, I created new PR #15 with the changes of this PR replacing libarchive-c with Python standard library tar/zip readers.
Thanks for having zig on PyPI, this makes installing it quite easy! This packaging tool is quite useful, here a PR to possibly add some more features:
python make_wheels.py --version master --suffix ""
)ziglang.__version__
) and an additional entrypoint (ziglang.zig("arg1", "arg2")
) to packageFurthermore, the
libarchive
dependency is removed. In general, I would not hardcode the--version
and--suffix
parameters as they are now to match the behavior of the old script. Using Github Actions, the packaging could be automated further.