ziglang / zig-pypi

The Zig programming language, packaged for PyPI
https://pypi.org/project/ziglang/
MIT License
148 stars 16 forks source link

Various improvements (version discovery via download JSON, CLI, etc) #10

Closed csachs closed 1 year ago

csachs commented 1 year ago

Thanks for having zig on PyPI, this makes installing it quite easy! This packaging tool is quite useful, here a PR to possibly add some more features:

Furthermore, the libarchive dependency is removed. In general, I would not hardcode the --version and --suffix parameters as they are now to match the behavior of the old script. Using Github Actions, the packaging could be automated further.

whitequark commented 1 year ago

Please split the pull request into several smaller ones so that your changes can be discussed and applied individually. At the moment I don't have the review bandwidth to look into it otherwise.

whitequark commented 1 year ago

I'm happy to continue review here. I'm particularly interested in the removal of libarchive-c dependency.

robtaylor commented 1 year ago

Interested also, currently builds seem to fail on latest macos

whitequark commented 1 year ago

As far as I understand this has been merged already.

csachs commented 12 months ago

I'm happy to continue review here. I'm particularly interested in the removal of libarchive-c dependency.

Sorry for the delay, I created new PR #15 with the changes of this PR replacing libarchive-c with Python standard library tar/zip readers.