search

ziglang / zig

General-purpose programming language and toolchain for maintaining robust, optimal, and reusable software.
https://ziglang.org
MIT License
34.58k stars 2.53k forks source link

Get CGO tests into passing state using `zig cc` as the host C compiler on macOS #21721

Open kubkon opened 1 week ago

kubkon commented 1 week ago

Zig Version

0.14.0-dev.1924+bdd3bc056

Steps to Reproduce and Observed Behavior

$ git clone https://github.com/golang/go --depth=1
$ cd go/src/cmd/cgo/internal/test
$ CC="zig cc" go test
# cmd/cgo/internal/test.test
/Users/kubkon/dev/go/pkg/tool/darwin_arm64/link: running /Users/kubkon/dev/zig/build/stage4/bin/zig failed: exit status 1
/Users/kubkon/dev/zig/build/stage4/bin/zig cc -arch arm64 -Wl,-S -Wl,-x -o $WORK/b001/test.test /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/go.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000000.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000001.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000002.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000003.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000004.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000005.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000006.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000007.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000008.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000009.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000010.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000011.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000012.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000013.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000014.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000015.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000016.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000017.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000018.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000019.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000020.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000021.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000022.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000023.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000024.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000025.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000026.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000027.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000028.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000029.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000030.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000031.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000032.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000033.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000034.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000035.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000036.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000037.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000038.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000039.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000040.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000041.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000042.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000043.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000044.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000045.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000046.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000047.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000048.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000049.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000050.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000051.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000052.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000053.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000054.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000055.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000056.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000057.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000058.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000059.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000060.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000061.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000062.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000063.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000064.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000065.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000066.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000067.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000068.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000069.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000070.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000071.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000072.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000073.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000074.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000075.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000076.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000077.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000078.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000079.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000080.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000081.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000082.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000083.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000084.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000085.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000086.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000087.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000088.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000089.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000090.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000091.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000092.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000093.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000094.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000095.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000096.o /var/folders/4q/vf2j8t9d1wj39dgmg_7xp12h0000gn/T/go-link-3019325478/000097.o -O2 -g -framework CoreFoundation -pthread -lresolv -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -O2 -g -framework CoreFoundation -framework CoreFoundation -O2 -g -framework CoreFoundation -framework Security -O2 -g -framework CoreFoundation -framework Security -O2 -g -framework CoreFoundation -framework Security -O2 -g -framework CoreFoundation -O2 -g -framework CoreFoundation -O2 -g -O2 -g
error: unsupported linker arg: -x

FAIL    cmd/cgo/internal/test [build failed]

According to Apple's ld man pages, -x stands for

     -x      Do not put non-global symbols in the output file's symbol table. Non-global symbols are useful when debugging and getting symbol names in back traces, but
             are not used at runtime. If -x is used with -r non-global symbol names are not removed, but instead replaced with a unique, dummy name that will be
             automatically removed when linked into a final linked image.  This allows dead code stripping, which uses symbols to break up code and data, to work
             properly and provides the security of having source symbol names removed.

Expected Behavior

Tests pass.

mark-rushakoff commented 4 days ago

I think this is the part in the Go source that is setting -Wl,x: https://github.com/golang/go/blob/f2d118fd5f7e872804a5825ce29797f81a28b0fa/src/cmd/link/internal/ld/lib.go#L1464-L1469

If it's helpful, the comment there says:

We are generating a binary with symbol table suppressed. Suppress local symbols. We need to keep dynamically exported and referenced symbols so the dynamic linker can resolve them.

That seems a little more specific on the intent, than the quoted manpage detail for ld -x.