make ACK dependents on packet.tx_options

zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices

GNU General Public License v3.0

179 stars 87 forks source link

Closed pipiche38 closed 1 year ago

pipiche38 commented 1 year ago

To prevent send_packet to always set APS_OPTION_RETRY check if packet tx_options requires or not ACK. Addressing #504

pipiche38 commented 1 year ago

Please let me know if there is any issue preventing merging that PR. I'll correct it

puddly commented 1 year ago

I will test this out later today

puddly commented 1 year ago

I can confirm with Wireshark that this does indeed make bellows respect the zigpy ACK options. Thanks!