Closed puddly closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
899218a
) compared to base (3340e12
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
What do you recommend ? I see that the default is to use the thread. In fact what is the benefit to use it ?
In fact what is the benefit to use it ?
There's no reason not to use it. If your event loop is busy or has stuttering, it will break EZSP communication with the radio. The only reason I'm adding this option is to allow bellows to be used in environments where threading is not implemented.
Not all environments support or need threading, namely https://pyscript.net/ and command line applications:
Once some hard-to-reproduce, low-level bugs are ironed out of the bellows asyncio thread, I think it would be beneficial to move it into zigpy.