codecov-commenter
commented
1 year ago Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
b7a3925) compared to base (a941dff). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #518 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 47 47 Lines 3305 3305 ========================================= Hits 3305 3305 ``` | [Impacted Files](https://codecov.io/gh/zigpy/bellows/pull/518?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/zigbee/util.py](https://codecov.io/gh/zigpy/bellows/pull/518/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvdXRpbC5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The unit tests accidentally used
returninstead ofassertand were actually failing.The side effect of this bug existing is that the outgoing frame counter was set equal to the incoming frame counter, which is often quite low (or zero) 🤦♂️.