zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
179 stars 87 forks source link

Handle new Xiaomi IEEE prefix #520

Closed puddly closed 1 year ago

puddly commented 1 year ago

Might fix https://github.com/home-assistant/core/issues/85179

puddly commented 1 year ago

Should we just add all of these? https://macaddress.io/statistics/company/14568

codecov-commenter commented 1 year ago

Codecov Report

Base: 99.80% // Head: 99.80% // No change to project coverage :thumbsup:

Coverage data is based on head (78cf9b0) compared to base (d6bd58d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #520 +/- ## ======================================= Coverage 99.80% 99.80% ======================================= Files 51 51 Lines 4170 4170 ======================================= Hits 4162 4162 Misses 8 8 ``` | [Impacted Files](https://codecov.io/gh/zigpy/bellows/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/zigbee/application.py](https://codecov.io/gh/zigpy/bellows/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvYXBwbGljYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MattWestb commented 1 year ago

I was not finding all prefixes for lumi that little strange. We dont knowing if they is using the IEEE for Zigbee / thread devices or BT, WiFi and Eth chips but if you is adding all it shall being future safe. You can also taking on look wot deCONZ have putting in there code.

MattWestb commented 1 year ago

DE is only using 2: https://github.com/dresden-elektronik/deconz-rest-plugin/blob/674d17143b0467d8a9d14d6f876cee753aa445b1/zdp/zdp_handlers.cpp#L297-L300

puddly commented 1 year ago

Interesting. Maybe 04:CF:FC in bellows is a typo and should be 04:CF:8C instead.

On the other hand, in the linked Home Assistant Core issue, if everything worked with the Conbee, it seems like its firmware might have a list as well?

MattWestb commented 1 year ago

Can bee that they have putting one list in the firmware and can adding more in the host system then using commands that need it. They was doing the same with default response and other APS acks is being done in the firmware and sending OK back to the host without the command is being acked OK from the device / mesh. The reason is then there code is too slow and cant doing it in the upper system.

I cant finding 04:CF:FC so i think its one typo.

TheJulianJES commented 1 year ago

Yeah, at least with ZHA, Conbee sticks need to have their firmware updated most of the time, or they're not sending the Xiaomi codes.

Z-Stack also uses the same addresses which deCONZ has: https://github.com/Koenkk/Z-Stack-firmware/blob/3406c6a0cd2b755f302f4cacd07b37497a86cc08/coordinator/Z-Stack_3.x.0/firmware.patch#L551-L552

So I'd also say that 04:CF:FC is a typo

Edit: report of another 04:CF:8C: https://github.com/zigpy/zha-device-handlers/issues/2044#issuecomment-1373945085

MattWestb commented 1 year ago

So 6 case saying saying typo = more then likely. Then the question shall wee adding many more IEEE ranges and making the system slower for all EZSP and deCONZ adapters then its not needed ?

MattWestb commented 1 year ago

Have you checking the code in the radio libs for deCONZ and TI if its also is OK ?

puddly commented 1 year ago

Bellows is the only library that handles these so I think we are fine. Z-Stack firmware is patched (https://github.com/zigpy/bellows/pull/520#issuecomment-1373927206) and the Conbee firmware seems to do it on its own.