Closed puddly closed 1 year ago
Should we just add all of these? https://macaddress.io/statistics/company/14568
Base: 99.80% // Head: 99.80% // No change to project coverage :thumbsup:
Coverage data is based on head (
78cf9b0
) compared to base (d6bd58d
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I was not finding all prefixes for lumi that little strange. We dont knowing if they is using the IEEE for Zigbee / thread devices or BT, WiFi and Eth chips but if you is adding all it shall being future safe. You can also taking on look wot deCONZ have putting in there code.
Interesting. Maybe 04:CF:FC
in bellows is a typo and should be 04:CF:8C
instead.
On the other hand, in the linked Home Assistant Core issue, if everything worked with the Conbee, it seems like its firmware might have a list as well?
Can bee that they have putting one list in the firmware and can adding more in the host system then using commands that need it. They was doing the same with default response and other APS acks is being done in the firmware and sending OK back to the host without the command is being acked OK from the device / mesh. The reason is then there code is too slow and cant doing it in the upper system.
I cant finding 04:CF:FC
so i think its one typo.
Yeah, at least with ZHA, Conbee sticks need to have their firmware updated most of the time, or they're not sending the Xiaomi codes.
Z-Stack also uses the same addresses which deCONZ has: https://github.com/Koenkk/Z-Stack-firmware/blob/3406c6a0cd2b755f302f4cacd07b37497a86cc08/coordinator/Z-Stack_3.x.0/firmware.patch#L551-L552
So I'd also say that 04:CF:FC is a typo
Edit: report of another 04:CF:8C: https://github.com/zigpy/zha-device-handlers/issues/2044#issuecomment-1373945085
So 6 case saying saying typo = more then likely. Then the question shall wee adding many more IEEE ranges and making the system slower for all EZSP and deCONZ adapters then its not needed ?
Have you checking the code in the radio libs for deCONZ and TI if its also is OK ?
Bellows is the only library that handles these so I think we are fine. Z-Stack firmware is patched (https://github.com/zigpy/bellows/pull/520#issuecomment-1373927206) and the Conbee firmware seems to do it on its own.
Might fix https://github.com/home-assistant/core/issues/85179