zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
179 stars 87 forks source link

Use global zigpy unicast concurrency limit #530

Closed puddly closed 1 year ago

puddly commented 1 year ago

Using CONFIG_APS_UNICAST_MESSAGE_COUNT as the concurrency limit seems like it can cause problems when the value is large (e.g. multi-PAN defaults to 64). Instead, it will default to 8.

To increase the concurrency limit, update the zigpy configuration:

zha:
  zigpy_config:
    max_concurrent_requests: ...
codecov-commenter commented 1 year ago

Codecov Report

Base: 99.75% // Head: 99.75% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (4fdeb8f) compared to base (46cfe04). Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #530 +/- ## ========================================== - Coverage 99.75% 99.75% -0.01% ========================================== Files 57 57 Lines 4541 4537 -4 ========================================== - Hits 4530 4526 -4 Misses 11 11 ``` | [Impacted Files](https://codecov.io/gh/zigpy/bellows/pull/530?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/zigbee/application.py](https://codecov.io/gh/zigpy/bellows/pull/530?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvYXBwbGljYXRpb24ucHk=) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.