Closed puddly closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
e700caf
) 99.75% compared to head (350936d
) 99.75%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Changes seem to work as expected btw
I don't know how it works with ezsp, but my experience on zigate is that by relying on this we were exhausting internal resources PDUs So it might be interesting to see the impact on large heavy network. And maybe having an easy way to disable this
On EmberZNet the only effect is that you run into NETWORK_BUSY
more quickly, which is expected since more group commands can be sent at once (e.g. group light color commands usually send on()
+ move_to_color()
).
And which layer handle the NETWORK_BUSY issue ? Is zigpy will do the retry or is that the above layer ?
Bellows tries three times if it's a transient error: https://github.com/zigpy/bellows/blob/e700caf2a50454d0060c3fcd5f67f4b49ebfce46/bellows/zigbee/application.py#L760-L786
This allows for the downstream application to send two consecutive group commands without waiting for a send confirmation for the first.