zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
177 stars 87 forks source link

Logistic LQI calculation #538

Closed puddly closed 1 year ago

puddly commented 1 year ago

Depends on https://github.com/zigpy/zigpy/pull/1183

The parameters need to be adjusted but the general idea is to remap the LQI calculation to be reversible and have better asymptotic behavior instead of merely clipping and linear interpolation (like we currently do):

image

x-axis is RSSI, y-axis is LQI.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 :warning:

Comparison is base (e700caf) 99.75% compared to head (70ab8f2) 99.71%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #538 +/- ## ========================================== - Coverage 99.75% 99.71% -0.05% ========================================== Files 57 61 +4 Lines 4537 4563 +26 ========================================== + Hits 4526 4550 +24 - Misses 11 13 +2 ``` | [Impacted Files](https://codecov.io/gh/zigpy/bellows/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/zigbee/device.py](https://codecov.io/gh/zigpy/bellows/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvZGV2aWNlLnB5) | `96.07% <ø> (-3.93%)` | :arrow_down: | | [bellows/zigbee/application.py](https://codecov.io/gh/zigpy/bellows/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvYXBwbGljYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [bellows/zigbee/util.py](https://codecov.io/gh/zigpy/bellows/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvdXRpbC5weQ==) | `100.00% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://codecov.io/gh/zigpy/bellows/pull/538/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.