zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
177 stars 87 forks source link

Replace `asyncio.wait_for` with `asyncio.timeout` #546

Closed puddly closed 1 year ago

puddly commented 1 year ago

See https://github.com/zigpy/zigpy/pull/1187.

This has the side effect of making ezsp.Protocol.command an async function instead of a sync function returning a future.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a1bcb88) 99.71% compared to head (962acc2) 99.71%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #546 +/- ## ======================================= Coverage 99.71% 99.71% ======================================= Files 61 61 Lines 4567 4581 +14 ======================================= + Hits 4554 4568 +14 Misses 13 13 ``` | [Impacted Files](https://codecov.io/gh/zigpy/bellows/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/ezsp/\_\_init\_\_.py](https://codecov.io/gh/zigpy/bellows/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL19faW5pdF9fLnB5) | `99.13% <100.00%> (+0.01%)` | :arrow_up: | | [bellows/ezsp/protocol.py](https://codecov.io/gh/zigpy/bellows/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3Byb3RvY29sLnB5) | `97.24% <100.00%> (+0.07%)` | :arrow_up: | | [bellows/uart.py](https://codecov.io/gh/zigpy/bellows/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy91YXJ0LnB5) | `100.00% <100.00%> (ø)` | | | [bellows/zigbee/application.py](https://codecov.io/gh/zigpy/bellows/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvYXBwbGljYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.