Closed puddly closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.04
:tada:
Comparison is base (
a73588d
) 99.71% compared to head (8fa5982
) 99.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Just checking, what does that means from a compatibility standpoint with the previous version ?
If I understood your PR, prior we had some restrictive values and now, by default we are following the default firmware values .
If I understood your PR, prior we had some restrictive values and now, by default we are following the default firmware values .
Yes. For example, if the firmware sets CONFIG_MULTICAST_TABLE_SIZE
to 100
, then it will be left at 100
. If the firmware sets it to 2
, it will be grown to 16
. The old behavior is to always set it to 16
.
Default config is moved out of the protocol-specific definitions and into the main bellows application. With this change, two types of config are introduced:
CONFIG_TC_REJOINS_USING_WELL_KNOWN_KEY_TIMEOUT_S
will always be set to an exact value.Any of this behavior can be overridden by either overriding the config with an explicit value within your configuration, or by setting it to
None
to prevent bellows from changing it at all.Fixes #543.