zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
177 stars 87 forks source link

Fix zigbeed network settings persistence bug #553

Closed puddly closed 1 year ago

puddly commented 1 year ago

Zigbeed has broken behavior when you try to form a network twice in a row, like we do when forming an initial one when energy scanning. For zigpy, this means that the temporary network we form when running an initial energy scan is the main network, ignoring the channel config and other settings we provide.

The only way I could find to fix this behavior (short of an upstream fix) is to disconnect from the serial port and reconnect.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8549f27) 99.76% compared to head (a5f0eed) 99.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #553 +/- ## ======================================= Coverage 99.76% 99.76% ======================================= Files 62 62 Lines 4586 4595 +9 ======================================= + Hits 4575 4584 +9 Misses 11 11 ``` | [Impacted Files](https://app.codecov.io/gh/zigpy/bellows/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/ezsp/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL19faW5pdF9fLnB5) | `99.14% <100.00%> (+0.01%)` | :arrow_up: | | [bellows/zigbee/application.py](https://app.codecov.io/gh/zigpy/bellows/pull/553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvYXBwbGljYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.