zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
177 stars 87 forks source link

Ensure startup config is tested on all EZSP versions #559

Closed puddly closed 1 year ago

puddly commented 1 year ago

557 broke startup for EZSPv11 because EZSP_VERSION was never set correctly in any of the protocol handlers. Startup is now explicitly tested on all versions. More exhaustive startup tests that use fewer mocks will be in a future PR.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f1fba64) 99.76% compared to head (a3d36e7) 99.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #559 +/- ## ======================================= Coverage 99.76% 99.76% ======================================= Files 62 62 Lines 4594 4594 ======================================= Hits 4583 4583 Misses 11 11 ``` | [Impacted Files](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/ezsp/config.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL2NvbmZpZy5weQ==) | `100.00% <ø> (ø)` | | | [bellows/ezsp/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL19faW5pdF9fLnB5) | `99.17% <100.00%> (ø)` | | | [bellows/ezsp/protocol.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3Byb3RvY29sLnB5) | `97.29% <100.00%> (ø)` | | | [bellows/ezsp/v10/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3YxMC9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [bellows/ezsp/v11/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3YxMS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [bellows/ezsp/v4/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3Y0L19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [bellows/ezsp/v5/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3Y1L19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [bellows/ezsp/v6/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3Y2L19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [bellows/ezsp/v7/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3Y3L19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [bellows/ezsp/v8/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL3Y4L19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/zigpy/bellows/pull/559?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.