zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
177 stars 87 forks source link

Reset after NVRAM changes #579

Closed puddly closed 10 months ago

puddly commented 11 months ago

Bellows can sometimes have issues forming new networks: settings are successfully written, the network starts up, a backup afterwards works, but upon reset the settings are lost/revert.

It seems that we need to write our EmberZNet config after reset, in addition to resetting after every NVRAM change.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4e8ad8c) 99.83% compared to head (ca8281a) 99.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #579 +/- ## ======================================= Coverage 99.83% 99.83% ======================================= Files 68 68 Lines 4858 4871 +13 ======================================= + Hits 4850 4863 +13 Misses 8 8 ``` | [Files Changed](https://app.codecov.io/gh/zigpy/bellows/pull/579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [bellows/ezsp/\_\_init\_\_.py](https://app.codecov.io/gh/zigpy/bellows/pull/579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy9lenNwL19faW5pdF9fLnB5) | `99.39% <100.00%> (+<0.01%)` | :arrow_up: | | [bellows/zigbee/application.py](https://app.codecov.io/gh/zigpy/bellows/pull/579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-YmVsbG93cy96aWdiZWUvYXBwbGljYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

puddly commented 11 months ago

Everything works with all of the coordinators I tested (including an ancient HUSBZB-1) but I'd appreciate a second check. I encountered this issue when working on https://github.com/home-assistant/core/pull/99482.