zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
182 stars 86 forks source link

Fix watchdog reset counter #609

Closed dmulcahey closed 8 months ago

dmulcahey commented 8 months ago

SSIA

pipiche38 commented 8 months ago

Can you kindly tell what was the issue ?

puddly commented 8 months ago

No issue, this just changes what the counter is counting. These counters aren't used for anything but diagnostics.

dmulcahey commented 8 months ago

no idea why this is needed all of the sudden: https://github.com/zigpy/bellows/pull/609/commits/fd957cc0d5b9715115885257cd0024a96cad4d8d

how were the tests passing before?

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d3ba62e) 99.73% compared to head (fd957cc) 99.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #609 +/- ## ======================================= Coverage 99.73% 99.73% ======================================= Files 74 74 Lines 4987 4987 ======================================= Hits 4974 4974 Misses 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.