zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
177 stars 86 forks source link

Properly handle NAK frames and implement retries #610

Closed puddly closed 5 months ago

puddly commented 5 months ago

This should significantly increase the reliability of communication and prevent what should have been simple ASH re-sends or timeouts from turning into full reconnects.


This change exists in #606 already, which will be merged in the next release cycle.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1c43536) 99.73% compared to head (eda3f2c) 99.58%.

:exclamation: Current head eda3f2c differs from pull request most recent head 932cc02. Consider uploading reports for the commit 932cc02 to get more accurate results

Files Patch % Lines
bellows/uart.py 77.77% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #610 +/- ## ========================================== - Coverage 99.73% 99.58% -0.16% ========================================== Files 74 74 Lines 4987 5014 +27 ========================================== + Hits 4974 4993 +19 - Misses 13 21 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.