search

zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
177 stars 86 forks source link

Support firmware extensions #611

Open puddly opened 5 months ago

puddly commented 5 months ago

(This is more of a test than anything else.)

Support firmware extensions that expose functionality not present in stock EmberZNet. As a demo, I've implemented a custom EmberZNet packet filter that should ensure all group traffic is passed through without needing to add the NCP to the group beforehand. This removes the need for bellows.multicast.

MattWestb commented 5 months ago

This is VERY interesting !! If its working well we need patching all current production firmware that is possible but i think it worth it. I have good contact with Garry R (down under) that is the maker or most free ones only Sonoff signed can being problems but the dev still having his git but have moving to other company. Any link to your added code for SS 5 as extension ?

MattWestb commented 5 months ago

By the way, filtering multicast frames commands that have the same TSN from the same source and destination shall it being in the firmware or in bellows then the factory one is not doing it so normally getting multiple events with the same command ?

puddly commented 2 months ago

Firmware side is here: https://github.com/NabuCasa/silabs-firmware-builder/pull/57

You can try pre-built firmwares for the SkyConnect and Yellow as well: https://github.com/NabuCasa/silabs-firmware-builder/actions/runs/8945075022#artifacts

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 73.41040% with 46 lines in your changes missing coverage. Please review.

Project coverage is 98.85%. Comparing base (09cf7ce) to head (f391150).

Files Patch % Lines
bellows/ezsp/__init__.py 38.00% 31 Missing :warning:
bellows/ezsp/xncp.py 86.04% 12 Missing :warning:
bellows/zigbee/application.py 86.95% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #611 +/- ## ========================================== - Coverage 99.72% 98.85% -0.87% ========================================== Files 75 76 +1 Lines 5002 5148 +146 ========================================== + Hits 4988 5089 +101 - Misses 14 59 +45 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.