Closed TheJulianJES closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.72%. Comparing base (
09cf7ce
) to head (6e051af
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think I've only ever seen top_level_module.__version__
. Putting it in module.application.zigbee.LIB_VERSION
makes it pretty much library-internal.
I think I've only ever seen
top_level_module.__version__
. Putting it inmodule.application.zigbee.LIB_VERSION
makes it pretty much library-internal.
Yeah, I don't expect anyone else to use this. This is just to fix the blocking call.
I just used LIB_VERSION
as the name, so it's clear that we don't access the EZSP version or whatever.
Or do you want something else?
Nope, it's all good the way it is. Thanks!
This moves the blocking metadata version call outside of the
load_network_info
coroutine that's run at startup. I'll do this for the other radio libraries too, just want to confirm if we want to have that constant namedLIB_VERSION
, justVERSION
,PACKAGE_VERSION
, orBELLOWS_VERSION
?The test still blocks when checking it, but that should be fine.