zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
179 stars 87 forks source link

Consolidate all EZSP types #634

Closed puddly closed 1 month ago

puddly commented 1 month ago

This PR removes all copy/pasted EZSP types from EZSP v4 through v14. This greatly reduces the amount of code and strips down the individual EZSP protocol handlers to just the basics: command definitions and version-specific operations.

A future PR will migrate all command structures to proper types with named parameters.

bellows unit tests don't really cover version-level command serialization and deserialization so there's a chance that some types are incorrect. Runtime tested with EZSP v8 and v13.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.15%. Comparing base (c763b6b) to head (9f71062).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #634 +/- ## ========================================== - Coverage 99.38% 99.15% -0.24% ========================================== Files 79 50 -29 Lines 5047 3412 -1635 ========================================== - Hits 5016 3383 -1633 + Misses 31 29 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.