zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
179 stars 87 forks source link

Convert command types to dictionaries #636

Closed puddly closed 1 month ago

puddly commented 1 month ago

I've converted the types of every command schema for EZSP v5-v14 from a tuple of types to a dict of types. Only EZSPv4 is left. There is currently a compatibility shim to handle tuple schemas but it will be removed once v4 is finished.

This really helps with log file and code readability. Future command sending syntax will allow mixing and matching args and kwargs but bellows will migrate to kwarg-only syntax.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.13%. Comparing base (64ba03d) to head (16f0e41).

Files Patch % Lines
bellows/ezsp/protocol.py 92.30% 1 Missing :warning:
bellows/zigbee/application.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #636 +/- ## ========================================== - Coverage 99.15% 99.13% -0.03% ========================================== Files 50 50 Lines 3447 3456 +9 ========================================== + Hits 3418 3426 +8 - Misses 29 30 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.