zigpy / bellows

A Python 3 project to implement EZSP for EmberZNet devices
GNU General Public License v3.0
179 stars 87 forks source link

Fix manufacturer string when terminating with both `\x00` and `\xFF` #638

Closed puddly closed 1 month ago

puddly commented 1 month ago

The manufacturer string in some boards is encoded strangely:

ffffffffffffffffffffffffffff0000

The null byte terminator should be used when encoding a valid string. This one, however, is not.

Instead of reading out 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFF we should return None.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.16%. Comparing base (c4578a0) to head (1464e7a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #638 +/- ## ======================================= Coverage 99.16% 99.16% ======================================= Files 50 50 Lines 3459 3460 +1 ======================================= + Hits 3430 3431 +1 Misses 29 29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.