search

zigpy / zha-device-handlers

ZHA device handlers bridge the functionality gap created when manufacturers deviate from the ZCL specification, handling deviations and exceptions by parsing custom messages to and from Zigbee devices.
Apache License 2.0
751 stars 688 forks source link

[Device Support Request] Add Double clicks to Ikea Open/Close remote #2439

Open okainov opened 1 year ago

okainov commented 1 year ago

Problem description

Ikea Open/Closed remote (https://github.com/zigpy/zha-device-handlers/blob/dev/zhaquirks/ikea/opencloseremote.py) doesn't report double clicks. It would be great to have ability to react on double clicks as well as on single ones to add more automation possibilities.

Solution description

There should be possibility to choose "On Double Click Open"/"On Double Click Close" for the remote.

Screenshots/Video

No response

Device signature

Device signature ```json [Paste the device signature here] ```

Diagnostic information

Diagnostic information ```json [Paste the diagnostic information here] ```

Logs

Logs ```python [Paste the logs here] ```

Custom quirk

Custom quirk ```python [Paste your custom quirk here] ```

Additional information

No response

MattWestb commented 1 year ago

You have 2 alternative to getting it working:

Then the device is very "Zigbee standard" and you like doing it not its not one zha-quirk thing is one custom automation you is looking for.

okainov commented 1 year ago

@MattWestb yeah, I have seen already some blog post making exactly option 2, I tried to make it working, got some kind of partial success, but I was thinking it would be great to have such a obvious possibility out-of-the-box to avoid custom automations...

MattWestb commented 1 year ago

Im very sure is not one thaing that belongs in the ZHA-Quirks but perhaps in HA -Blueprints or one custom quirks if its possible implanting in them. The OnOff and OpenClose is sharing the firmware and only have different data settings that make them sending light or clover commands very Zigbee standard. The OpenClose have implanting release from long press by remember the last long press and its made in the quirk. The only function that was not standard of IKEA controllers was the battery reporting and looks being fixed inn the last OTA for most devices so they dont need some quirk for working OK in ZHA but is not getting Device Automatons (DA) from the quirk is not loading it. If some line doing local quirk or bueprint for the function i think its great but i think is not going true the maintainers if try implanting in the ZHA-Quirks. I think it can being good for some user cases but in the ground is one blind controller and not one click click (ala Aqara / tuya) and shall being used for that purposes.

By the was the gen 2 2 button controllers is in the pipe (Rodert) and is having both OnOff, OpenClose and ShurtCutt buttons on the same hardware and is on some IKEA homepages (Sweden and some more) and i think its open one way converting them for sending more commands.

TheJulianJES commented 1 year ago

We already have some logic for "virtual multi-presses" for the Hue remotes. We could try to make that more generic and apply it to more/all remotes.

Doing this in HA with blueprints isn’t as easy as using a device trigger (I think?)

MattWestb commented 1 year ago

We already have some logic for "virtual multi-presses" for the Hue remotes. We could try to make that more generic and apply it to more/all remotes.

Doing this in HA with blueprints isn’t as easy as using a device trigger (I think?)

I was think ZHA was using the HUE special commands sent from the device and not using the Zigbee light commands. https://github.com/zigpy/zha-device-handlers/blob/1e619d84a676347af3fa115f7f3af90f9550fc15/zhaquirks/philips/rdm001.py#L69 and then doing some "magic" from them.

TheJulianJES commented 1 year ago

Also see: https://github.com/zigpy/zha-device-handlers/blob/1e619d84a676347af3fa115f7f3af90f9550fc15/zhaquirks/philips/__init__.py#L103-L220

github-actions[bot] commented 10 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

okainov commented 10 months ago

Nothing has changed here

github-actions[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

okainov commented 4 months ago

Come on, nothing has changed here and it would be still a nice addition.

MattWestb commented 4 months ago

I think the easiest is getting one IKEA SOMRIG shortcut button its have short. double and long with release on both buttons (it can being IKEA is implanting more the its using Matter standard commands that is open for very many fast clicks).