github-actions[bot]
commented
5 days ago There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.
Problem description
Hi all, I'd like support for this TUYA roller blind, sold here https://www.zemismart.com/products/zm25r3
The blind reports 5 tuya data points in set_data_response and doesn't seem like a good match for the existing tuya cover quirks. (The existing quirks I tried were able to command it to move, but don't decode it's status/position.)
I've made good progress writing a custom quirk (it all looks like it works) but have few questions:
Any idea why battery remaining doesn't work? I can see in the log my quirk is updating the power cluster attribute, but home assistant shows unknown. Resolved: I didn't have a power cluster derived from LocalDataClusterIs this the right way to map from commands to a send DPs to the TUYA device. I copied this from some of the existing TuyaMCUCluster-based examples (e.g. TuyaRCBOMetering.) It seems a bit abstract to override the command method just to map to an attribute, especially when no standard attribute exists. Resolved: seems like the accepted way to do it.Any idea why the _CONSTANT_ATTRIBUTES don't work? (I was hoping these might fix the battery and show the window cover type, but HA doesn't show values in the entity nor when reading the zigbee attributes. Resolved: same or similar as battery problem.Do I need to consider using TuyaNoBindPowerConfigurationCluster or the tuya spell variants? (How would I know if I do?) Resolved: appears to work fine without it.Solution description
Fix battery percent in my custom quirk New quirk integrated in zha without needing a custom one.
Screenshots/Video
Screenshots/Video
[Paste/upload your media here]Device signature
Device signature
```json { "node_descriptor": "NodeDescriptor(logical_type=Diagnostic information
Diagnostic information
```json { "home_assistant": { "installation_type": "Home Assistant OS", "version": "2024.3.1", "dev": false, "hassio": true, "virtualenv": false, "python_version": "3.12.2", "docker": true, "arch": "x86_64", "timezone": "Australia/Brisbane", "os_name": "Linux", "os_version": "6.6.20-haos", "supervisor": "2024.03.0", "host_os": "Home Assistant OS 12.1", "docker_version": "24.0.7", "chassis": "vm", "run_as_root": true }, "custom_components": { "sonoff": { "version": "3.6.0", "requirements": [ "pycryptodome>=3.6.6" ] }, "meross_lan": { "version": "5.0.2", "requirements": [] }, "hacs": { "version": "1.34.0", "requirements": [ "aiogithubapi>=22.10.1" ] }, "spotcast": { "version": "v3.6.30", "requirements": [] }, "zha_toolkit": { "version": "v1.1.10", "requirements": [ "pytz" ] } }, "integration_manifest": { "domain": "zha", "name": "Zigbee Home Automation", "after_dependencies": [ "onboarding", "usb" ], "codeowners": [ "@dmulcahey", "@adminiuga", "@puddly", "@TheJulianJES" ], "config_flow": true, "dependencies": [ "file_upload" ], "documentation": "https://www.home-assistant.io/integrations/zha", "import_executor": true, "iot_class": "local_polling", "loggers": [ "aiosqlite", "bellows", "crccheck", "pure_pcapy3", "zhaquirks", "zigpy", "zigpy_deconz", "zigpy_xbee", "zigpy_zigate", "zigpy_znp", "universal_silabs_flasher" ], "requirements": [ "bellows==0.38.1", "pyserial==3.5", "pyserial-asyncio==0.6", "zha-quirks==0.0.112", "zigpy-deconz==0.23.1", "zigpy==0.63.4", "zigpy-xbee==0.20.1", "zigpy-zigate==0.12.0", "zigpy-znp==0.12.1", "universal-silabs-flasher==0.0.18", "pyserial-asyncio-fast==0.11" ], "usb": [ { "vid": "10C4", "pid": "EA60", "description": "*2652*", "known_devices": [ "slae.sh cc2652rb stick" ] }, { "vid": "10C4", "pid": "EA60", "description": "*slzb-07*", "known_devices": [ "smlight slzb-07" ] }, { "vid": "1A86", "pid": "55D4", "description": "*sonoff*plus*", "known_devices": [ "sonoff zigbee dongle plus v2" ] }, { "vid": "10C4", "pid": "EA60", "description": "*sonoff*plus*", "known_devices": [ "sonoff zigbee dongle plus" ] }, { "vid": "10C4", "pid": "EA60", "description": "*tubeszb*", "known_devices": [ "TubesZB Coordinator" ] }, { "vid": "1A86", "pid": "7523", "description": "*tubeszb*", "known_devices": [ "TubesZB Coordinator" ] }, { "vid": "1A86", "pid": "7523", "description": "*zigstar*", "known_devices": [ "ZigStar Coordinators" ] }, { "vid": "1CF1", "pid": "0030", "description": "*conbee*", "known_devices": [ "Conbee II" ] }, { "vid": "0403", "pid": "6015", "description": "*conbee*", "known_devices": [ "Conbee III" ] }, { "vid": "10C4", "pid": "8A2A", "description": "*zigbee*", "known_devices": [ "Nortek HUSBZB-1" ] }, { "vid": "0403", "pid": "6015", "description": "*zigate*", "known_devices": [ "ZiGate+" ] }, { "vid": "10C4", "pid": "EA60", "description": "*zigate*", "known_devices": [ "ZiGate" ] }, { "vid": "10C4", "pid": "8B34", "description": "*bv 2010/10*", "known_devices": [ "Bitron Video AV2010/10" ] } ], "zeroconf": [ { "type": "_esphomelib._tcp.local.", "name": "tube*" }, { "type": "_zigate-zigbee-gateway._tcp.local.", "name": "*zigate*" }, { "type": "_zigstar_gw._tcp.local.", "name": "*zigstar*" }, { "type": "_uzg-01._tcp.local.", "name": "uzg-01*" }, { "type": "_slzb-06._tcp.local.", "name": "slzb-06*" } ], "is_built_in": true }, "data": { "ieee": "**REDACTED**", "nwk": 19527, "manufacturer": "_TZE200_eevqq1uv", "model": "TS0601", "name": "_TZE200_eevqq1uv TS0601", "quirk_applied": false, "quirk_class": "zigpy.device.Device", "quirk_id": null, "manufacturer_code": 4098, "power_source": "Battery or Unknown", "lqi": 124, "rssi": -69, "last_seen": "2024-03-25T22:58:25", "available": true, "device_type": "EndDevice", "signature": { "node_descriptor": "NodeDescriptor(logical_type=Logs
Logs
When using one of the existing TUYA cover quirks: ```python Sending a up/down command 2024-03-19 22:39:04.260 DEBUG (MainThread) [zhaquirks.tuya] 84:b4:db:ff:fe:c0:95:98 Sending Tuya Cluster Command.. Manufacturer is _TZE200_eevqq1uv Cluster Command is 0x0001, Arguments are () 2024-03-19 22:39:04.260 DEBUG (MainThread) [zhaquirks.tuya] 84:b4:db:ff:fe:c0:95:98 Sending Tuya Command. Paylod values [endpoint_id : 1, Status : 0, TSN: 0, Command: 0x0401, Function: 0, Data: [1, 2]] 2024-03-19 22:39:04.260 DEBUG (MainThread) [zigpy.zcl] [0x7106:1:0xef00] Sending request header: ZCLHeader(frame_control=FrameControl<0x05>(frame_type=Custom quirk
Custom quirk
```python """Tuya based cover and blinds.""" import logging from typing import Any, Optional, Union import zigpy.types as t from zigpy.profiles import zha from zigpy.zcl import foundation from zigpy.zcl.clusters.general import ( Basic, Groups, Identify, OnOff, Ota, PowerConfiguration, Scenes, Time, ) from zigpy.zcl.clusters.closures import ( WindowCovering, ) from zhaquirks.const import ( DEVICE_TYPE, ENDPOINTS, INPUT_CLUSTERS, MODELS_INFO, OUTPUT_CLUSTERS, PROFILE_ID, ) from zhaquirks.tuya import ( CustomDevice, TUYA_MCU_COMMAND, TuyaDatapointData, TuyaLocalCluster ) from zhaquirks.tuya.mcu import DPToAttributeMapping, TuyaClusterData, TuyaMCUCluster # TODO - access these from WindowCover.ServerCommandDefs WINDOW_COVER_COMMAND_UPOPEN = 0x0000 WINDOW_COVER_COMMAND_DOWNCLOSE = 0x0001 WINDOW_COVER_COMMAND_STOP = 0x0002 WINDOW_COVER_COMMAND_LIFTPERCENT = 0x0005 WINDOW_COVER_COMMAND_CUSTOM = 0x0006 # --------------------------------------------------------- # TUYA Cover Custom Values # --------------------------------------------------------- ATTR_COVER_DIRECTION = 0x8001 ATTR_COVER_DIRECTION_NAME = "motor_direction" ATTR_COVER_INVERTED = 0x8002 ATTR_COVER_LIFTPERCENT_NAME = "current_position_lift_percentage" ATTR_COVER_LIFTPERCENT_CONTROL = 0x8003 ATTR_COVER_LIFTPERCENT_CONTROL_NAME = "current_position_lift_percentage_control" _LOGGER = logging.getLogger(__name__) class CoverMotionCommandDirection(t.enum8): """window cover motion command direction enum.""" Open = 0x00 Close = 0x02 Stop = 0x01 class TuyaNewWindowCoverCluster(WindowCovering, TuyaLocalCluster): """Tuya Window Cover Cluster""" # Use TuyaLocalCluster to disable attribute writes, compatible with TuyaNewManufCluster (not # TuyaManufCluster.) attributes = WindowCovering.attributes.copy() attributes.update({ATTR_COVER_DIRECTION: ("motor_direction", t.enum8, True)}) attributes.update({ATTR_COVER_INVERTED: ("cover_inverted", t.Bool)}) attributes.update({ATTR_COVER_LIFTPERCENT_CONTROL: (ATTR_COVER_LIFTPERCENT_CONTROL_NAME, t.uint16_t)}) # For most tuya devices 0 = Up/Open, 1 = Stop, 2 = Down/Close tuya_cover_command: dict[int, CoverMotionCommandDirection] = { WINDOW_COVER_COMMAND_UPOPEN: CoverMotionCommandDirection.Open, WINDOW_COVER_COMMAND_DOWNCLOSE: CoverMotionCommandDirection.Close, WINDOW_COVER_COMMAND_STOP: CoverMotionCommandDirection.Stop, } async def command( self, command_id: Union[foundation.GeneralCommand, int, t.uint8_t], *args, manufacturer: Optional[Union[int, t.uint16_t]] = None, expect_reply: bool = True, tsn: Optional[Union[int, t.uint8_t]] = None, ): """Override the default Cluster command.""" _LOGGER.debug( "Sending Tuya Cluster Command... Cluster Command is %x, Arguments are %s", command_id, args, ) # Open Close or Stop commands if command_id in ( WINDOW_COVER_COMMAND_UPOPEN, WINDOW_COVER_COMMAND_DOWNCLOSE, WINDOW_COVER_COMMAND_STOP, ): # TODO - Copy more functionality from TuyaWindowCoverControl to handle inverted # controls here, in set by position, and perhaps decoding the current position cluster_data = TuyaClusterData( endpoint_id=self.endpoint.endpoint_id, cluster_name=self.ep_attribute, cluster_attr=ATTR_COVER_DIRECTION_NAME, # Map from zigbee command to tuya DP value attr_value=self.tuya_cover_command[command_id], expect_reply=expect_reply, manufacturer=manufacturer, ) self.endpoint.device.command_bus.listener_event( TUYA_MCU_COMMAND, cluster_data, ) return foundation.GENERAL_COMMANDS[ foundation.GeneralCommand.Default_Response ].schema(command_id=command_id, status=foundation.Status.SUCCESS) elif command_id == WINDOW_COVER_COMMAND_LIFTPERCENT: # TODO - This isn't working, sending set_data DP3 doesn't move the blind # TODO - Handle inverted lift vs. closed percent cluster_data = TuyaClusterData( endpoint_id=self.endpoint.endpoint_id, cluster_name=self.ep_attribute, cluster_attr=ATTR_COVER_LIFTPERCENT_CONTROL_NAME, attr_value=args[0], expect_reply=expect_reply, manufacturer=manufacturer, ) self.endpoint.device.command_bus.listener_event( TUYA_MCU_COMMAND, cluster_data, ) return foundation.GENERAL_COMMANDS[ foundation.GeneralCommand.Default_Response ].schema(command_id=command_id, status=foundation.Status.SUCCESS) _LOGGER.warning("Unsupported command_id: %s", command_id) return foundation.GENERAL_COMMANDS[ foundation.GeneralCommand.Default_Response ].schema(command_id=command_id, status=foundation.Status.UNSUP_CLUSTER_COMMAND) class TuyaNewPowerConfigurationCluster(PowerConfiguration, TuyaLocalCluster): """PowerConfiguration cluster reliant on TUYA data point decoding.""" class TuyaMCUClusterForWindowCover(TuyaMCUCluster): """Tuya translations between attributes and MCU data point commands""" dp_to_attribute: dict[int, DPToAttributeMapping] = { 1: DPToAttributeMapping( TuyaNewWindowCoverCluster.ep_attribute, ATTR_COVER_DIRECTION_NAME ), 2: DPToAttributeMapping( TuyaNewWindowCoverCluster.ep_attribute, ATTR_COVER_LIFTPERCENT_CONTROL_NAME, # blind reports % closed, cluster attribute is % open lambda x: 100 - x, lambda x: 100 - x ), 3: DPToAttributeMapping( TuyaNewWindowCoverCluster.ep_attribute, ATTR_COVER_LIFTPERCENT_NAME, # blind reports % closed, cluster attribute is % open lambda x: 100 - x, lambda x: 100 - x ), 13: DPToAttributeMapping( PowerConfiguration.ep_attribute, "battery_percentage_remaining", # zigbee spec for battery is to return percent x 2 lambda x: x * 2 ), } data_point_handlers = { 1: "_dp_2_attr_update", 2: "_dp_2_attr_update", 3: "_dp_2_attr_update", # Define DPs 5 & 7 to avoid warning logs, but I'm not sure what they are so just ignore # updates from them 5: "ignore_update", 7: "ignore_update", 13: "_dp_2_attr_update", } def ignore_update(self, datapoint: TuyaDatapointData) -> None: return None class TuyaCover0601MultipleDataPoints(CustomDevice): """Tuya blind controller device, sending multiple data points in set_data_response.""" signature = { MODELS_INFO: [ ("_TZE200_eevqq1uv", "TS0601"), # Zemismart ZM25R3 ], ENDPOINTS: { 1: { PROFILE_ID: zha.PROFILE_ID, DEVICE_TYPE: zha.DeviceType.SMART_PLUG, INPUT_CLUSTERS: [ Basic.cluster_id, Groups.cluster_id, Scenes.cluster_id, TuyaMCUCluster.cluster_id, ], OUTPUT_CLUSTERS: [Time.cluster_id, Ota.cluster_id], } }, } replacement = { ENDPOINTS: { 1: { DEVICE_TYPE: zha.DeviceType.WINDOW_COVERING_DEVICE, INPUT_CLUSTERS: [ Basic.cluster_id, Groups.cluster_id, Scenes.cluster_id, TuyaNewWindowCoverCluster, TuyaNewPowerConfigurationCluster, TuyaMCUClusterForWindowCover, ], OUTPUT_CLUSTERS: [Time.cluster_id, Ota.cluster_id], } } } ```Additional information
No response