search

zigpy / zigpy-deconz

A library which communicates with Deconz radios for zigpy
GNU General Public License v3.0
85 stars 20 forks source link

self._uart.send - AttributeError: 'NoneType' object has no attribute 'send' #256

Closed rrooggiieerr closed 3 weeks ago

rrooggiieerr commented 1 month ago

I'm using a RaspBee II and these errors are logged in my home-assistant.log. Seems that the uart gets reset somehow and the code dan't really cope with that.

2024-05-24 03:13:54.655 WARNING (MainThread) [zigpy.application] Watchdog failure                                                                                                       
Traceback (most recent call last):                                                                                                                                                      
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 589, in _command                                                                                             
    return await fut                                                                                                                                                                    
           ^^^^^^^^^                                                                                                                                                                    
asyncio.exceptions.CancelledError                                                                                                                                                       

The above exception was the direct cause of the following exception:                                                                                                                    

Traceback (most recent call last):                                                                                                                                                      
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 673, in _watchdog_loop                                                                                      
    await self.watchdog_feed()                                                                                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 655, in watchdog_feed                                                                                       
    await self._watchdog_feed()                                                                                                                                              
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/zigbee/application.py", line 87, in _watchdog_feed                                                                         
    await self._api.write_parameter(                                                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 849, in write_parameter                                                                         
    await self.send_command(                                                                                                   
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 508, in send_command                                                                                         
    return await self._command(cmd, **kwargs)                                                                                                                                          
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                           
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 588, in _command                                                                        
    async with asyncio_timeout(COMMAND_TIMEOUT):                                                                               
  File "/usr/local/lib/python3.12/asyncio/timeouts.py", line 115, in __aexit__                                                 
    raise TimeoutError from exc_val                                                                                            
TimeoutError                                                                                                                   
2024-05-24 03:13:56.683 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved                                                                          
Traceback (most recent call last):                                                                                                                                                      
  File "/usr/src/homeassistant/homeassistant/components/zha/sensor.py", line 272, in _refresh                                                                                           
    await self.async_update()                                                                                                                                                           
  File "/usr/src/homeassistant/homeassistant/components/zha/entity.py", line 256, in async_update                                                                                       
    await asyncio.gather(*tasks)                                                                                                                                                        
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/homeautomation.py", line 128, in async_update                                                         
    result = await self.get_attributes(attrs, from_cache=False, only_cache=False)                                                                                                       
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                       
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/__init__.py", line 514, in _get_attributes                                                            
    read, _ = await self.cluster.read_attributes(                                                                                                                                       
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 528, in read_attributes                                                                                    
    result = await self.read_attributes_raw(to_read, manufacturer=manufacturer)                                                                                                         
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                         
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 289, in read_attributes_raw                                                                             
    results = await super().read_attributes_raw(                                                                                                                             
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                        
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 334, in _read_attributes                                                                   
    return await super()._read_attributes(                                                                                                                                 
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                     
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 377, in request                                                                                            
    return await self._endpoint.request(                                                                                                                                               
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                
  File "/usr/local/lib/python3.12/site-packages/zigpy/endpoint.py", line 265, in request                                                                           
    return await self.device.request(                                                                                          
           ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy/device.py", line 339, in request                                         
    await send_request()                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 841, in request                                    
    await self.send_packet(                                                                                                    
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/zigbee/application.py", line 508, in send_packet                  
    await self._api.aps_data_request(                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 882, in aps_data_request                            
    rsp = await self.send_command(                                                                                             
          ^^^^^^^^^^^^^^^^^^^^^^^^                                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 508, in send_command                                
    return await self._command(cmd, **kwargs)                                                                                  
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                  
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 586, in _command                                    
    self._uart.send(command.replace(seq=seq).serialize())                                                                              
    ^^^^^^^^^^^^^^^                                                                                                                                                
AttributeError: 'NoneType' object has no attribute 'send'                                                                      
2024-05-24 03:13:57.107 ERROR (MainThread) [zigpy.zcl] [0x555B:1:0xef00] Traceback (most recent call last):                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 415, in reply                                                                                              
    return await self._endpoint.reply(                                                                                                                                                  
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                  
  File "/usr/local/lib/python3.12/site-packages/zigpy/endpoint.py", line 290, in reply                                                                                                  
    return await self.device.reply(                                                                                                                                                     
           ^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                     
  File "/usr/local/lib/python3.12/site-packages/zigpy/device.py", line 508, in reply                                                                                                    
    return await self.request(                                                                                                                                                          
           ^^^^^^^^^^^^^^^^^^^                                                                                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy/device.py", line 334, in request                                                                                                  
    await send_request()                                                                                                                                                                
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 841, in request                                                                                             
    await self.send_packet(                                                                                                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/zigbee/application.py", line 508, in send_packet                                                                           
    await self._api.aps_data_request(                                                                                                                                        
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 882, in aps_data_request                                                                                     
    rsp = await self.send_command(                                                                                                                                         
          ^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                         
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 508, in send_command                                
    return await self._command(cmd, **kwargs)                                                                                                                                           
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 586, in _command                                                                                             
    self._uart.send(command.replace(seq=seq).serialize())                                                                                                          
    ^^^^^^^^^^^^^^^                                                                                                            
AttributeError: 'NoneType' object has no attribute 'send'                                                                      

2024-05-24 03:13:57.109 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved                                                                          
Traceback (most recent call last):                                                                                                                                                      
  File "/usr/src/homeassistant/homeassistant/components/zha/sensor.py", line 272, in _refresh                                                                                           
    await self.async_update()                                                                                                                                                           
  File "/usr/src/homeassistant/homeassistant/components/zha/entity.py", line 256, in async_update                                                                                       
    await asyncio.gather(*tasks)                                                                                                                                                        
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/homeautomation.py", line 128, in async_update                                                         
    result = await self.get_attributes(attrs, from_cache=False, only_cache=False)                                                                                                       
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                       
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/__init__.py", line 514, in _get_attributes                                                            
    read, _ = await self.cluster.read_attributes(                                                                                                                                       
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 528, in read_attributes                                                                                    
    result = await self.read_attributes_raw(to_read, manufacturer=manufacturer)                                                                                                         
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                              
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 289, in read_attributes_raw                                                                             
    results = await super().read_attributes_raw(                                                                                                                           
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                           
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 334, in _read_attributes                       
    return await super()._read_attributes(                                                                                                                                              
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 377, in request                                                                                            
    return await self._endpoint.request(                                                                                                                           
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/endpoint.py", line 265, in request                                       
    return await self.device.request(                                                                                          
           ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy/device.py", line 339, in request                                         
    await send_request()                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 841, in request                                    
    await self.send_packet(                                                                                                    
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/zigbee/application.py", line 508, in send_packet                  
    await self._api.aps_data_request(                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 882, in aps_data_request                            
    rsp = await self.send_command(                                                                                             
          ^^^^^^^^^^^^^^^^^^^^^^^^                                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 508, in send_command                                
    return await self._command(cmd, **kwargs)                                                                                  
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 586, in _command                                                                        
    self._uart.send(command.replace(seq=seq).serialize())                                                                      
    ^^^^^^^^^^^^^^^                                                                                                            
AttributeError: 'NoneType' object has no attribute 'send'                                                                      
2024-05-24 03:13:57.182 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved                                                                          
Traceback (most recent call last):                                                                                                                                                      
  File "/usr/src/homeassistant/homeassistant/components/zha/sensor.py", line 272, in _refresh                                                                                           
    await self.async_update()                                                                                                                                                           
  File "/usr/src/homeassistant/homeassistant/components/zha/entity.py", line 256, in async_update                                                                                       
    await asyncio.gather(*tasks)                                                                                                                                                        
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/homeautomation.py", line 128, in async_update                                                         
    result = await self.get_attributes(attrs, from_cache=False, only_cache=False)                                                                                                       
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                       
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/__init__.py", line 514, in _get_attributes                                                            
    read, _ = await self.cluster.read_attributes(                                                                                                                                       
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 528, in read_attributes                                                                                    
    result = await self.read_attributes_raw(to_read, manufacturer=manufacturer)                                                                                                         
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                         
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 289, in read_attributes_raw                                                                  
    results = await super().read_attributes_raw(                                                                                                                                        
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                           
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 334, in _read_attributes                                                                   
    return await super()._read_attributes(                                                                                     
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                              
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 377, in request                                                                                           
    return await self._endpoint.request(                                                                                                                                                
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                           
  File "/usr/local/lib/python3.12/site-packages/zigpy/endpoint.py", line 265, in request                                       
    return await self.device.request(                                                                                          
           ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy/device.py", line 339, in request                                         
    await send_request()                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 841, in request                                    
    await self.send_packet(                                                                                                    
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/zigbee/application.py", line 508, in send_packet                  
    await self._api.aps_data_request(                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 882, in aps_data_request                            
    rsp = await self.send_command(                                                                                             
          ^^^^^^^^^^^^^^^^^^^^^^^^                                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 508, in send_command                                
    return await self._command(cmd, **kwargs)                                                                                  
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                  
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 586, in _command                                            
    self._uart.send(command.replace(seq=seq).serialize())                                                                                                          
    ^^^^^^^^^^^^^^^                                                                                                            
AttributeError: 'NoneType' object has no attribute 'send'                                                                      
2024-05-24 03:13:59.116 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved                                                                          
Traceback (most recent call last):                                                                                                                                                      
  File "/usr/src/homeassistant/homeassistant/components/zha/sensor.py", line 272, in _refresh                                                                                           
    await self.async_update()                                                                                                                                                           
  File "/usr/src/homeassistant/homeassistant/components/zha/entity.py", line 256, in async_update                                                                                       
    await asyncio.gather(*tasks)                                                                                                                                                        
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/homeautomation.py", line 128, in async_update                                                         
    result = await self.get_attributes(attrs, from_cache=False, only_cache=False)                                                                                                       
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                       
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/__init__.py", line 514, in _get_attributes                                                            
    read, _ = await self.cluster.read_attributes(                                                                                                                                       
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 528, in read_attributes                                                                                    
    result = await self.read_attributes_raw(to_read, manufacturer=manufacturer)                                                                                                         
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                         
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 289, in read_attributes_raw                                                                  
    results = await super().read_attributes_raw(                                                                                                                                        
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                           
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 334, in _read_attributes                                                                   
    return await super()._read_attributes(                                                                                     
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                              
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 377, in request                                                                                           
    return await self._endpoint.request(                                                                                                                                                
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                           
  File "/usr/local/lib/python3.12/site-packages/zigpy/endpoint.py", line 265, in request                                       
    return await self.device.request(                                                                                          
           ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy/device.py", line 339, in request                                         
    await send_request()                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 841, in request                                    
    await self.send_packet(                                                                                                    
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/zigbee/application.py", line 508, in send_packet                  
    await self._api.aps_data_request(                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 882, in aps_data_request                            
    rsp = await self.send_command(                                                                                             
          ^^^^^^^^^^^^^^^^^^^^^^^^                                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 508, in send_command                                
    return await self._command(cmd, **kwargs)                                                                                  
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                  
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/api.py", line 586, in _command                                            
    self._uart.send(command.replace(seq=seq).serialize())                                                                                                          
    ^^^^^^^^^^^^^^^                                                                                                            
AttributeError: 'NoneType' object has no attribute 'send'                                                                      
2024-05-24 03:13:59.225 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved                                                                          
Traceback (most recent call last):                                                                                                                                                      
  File "/usr/src/homeassistant/homeassistant/components/zha/sensor.py", line 272, in _refresh                                                                                           
    await self.async_update()                                                                                                                                                           
  File "/usr/src/homeassistant/homeassistant/components/zha/entity.py", line 256, in async_update                                                                                       
    await asyncio.gather(*tasks)                                                                                                                                                        
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/smartenergy.py", line 325, in async_update                                                            
    result = await self.get_attributes(attrs, from_cache=False, only_cache=False)                                                                                                       
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                       
  File "/usr/src/homeassistant/homeassistant/components/zha/core/cluster_handlers/__init__.py", line 514, in _get_attributes                                                            
    read, _ = await self.cluster.read_attributes(                                                                                                                                       
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 528, in read_attributes                                                                                    
    result = await self.read_attributes_raw(to_read, manufacturer=manufacturer)                                                                                                         
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                         
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 289, in read_attributes_raw                                                                             
    results = await super().read_attributes_raw(                                                                                                                                        
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                             
  File "/usr/local/lib/python3.12/site-packages/zigpy/quirks/__init__.py", line 334, in _read_attributes                                                                                
    return await super()._read_attributes(                                                                                                                                 
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                 
  File "/usr/local/lib/python3.12/site-packages/zigpy/zcl/__init__.py", line 377, in request                                   
    return await self._endpoint.request(                                                                                                                                                
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                               
  File "/usr/local/lib/python3.12/site-packages/zigpy/endpoint.py", line 265, in request                                                                                                
    return await self.device.request(                                                                                                                              
           ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                          
  File "/usr/local/lib/python3.12/site-packages/zigpy/device.py", line 339, in request                                         
    await send_request()                                                                                                       
  File "/usr/local/lib/python3.12/site-packages/zigpy/application.py", line 841, in request                                    
    await self.send_packet(                                                                                                    
  File "/usr/local/lib/python3.12/site-packages/zigpy_deconz/zigbee/application.py", line 508, in send_packet                  
    await self._api.aps_data_request(                                                                                          
          ^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                           
AttributeError: 'NoneType' object has no attribute 'aps_data_request'
rrooggiieerr commented 3 weeks ago

@Adminiuga @puddly Any chance to have a look at this?

puddly commented 3 weeks ago

A watchdog failure isn't good. Your device stops responding to serial traffic.

These are caused outstanding/pending commands that fail due to the adapter disconnecting. You'll get some sort of error message either way.

rrooggiieerr commented 3 weeks ago

Ok, I'm suspecting one of my custom HA integrations was doing blocking IO which was triggering the Watchdog and restarting the serial interface to my RaspBee II. I've upgraded some of my custom integrations and the issue has not shown up since.