Closed Shulyaka closed 9 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
098b19c
) 99.87% compared to head (d1b4cd2
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For this PR, I'm hoping to implement https://github.com/zigpy/zigpy/pull/1261, since the install code can be converted into a link key before getting to the radio library. It looks like XBee implements both at the moment with a simple enum to swap between the two?
I think it's enough to just implement joining with a key and provide a stub implementation of the old method.
For comparison, here's a PR for zigpy-znp implementing this: https://github.com/zigpy/zigpy-znp/pull/226/files
I'll make a PR removing the stub from radio libraries in the future.
Yes, XBee supports both link keys and install codes, converting the code to the key on device. I will update the PR.
Done.
When a default permit_with_key
method is implemented, we can delete the xbee method (and the key_type
argument).
Add support for device joining via install codes.
Successful logs:
Unsuccessful logs (invalid IEEE provided):