search

zigpy / zigpy-znp

TI CC2531, CC13x2, CC26x2 radio support for Zigpy and ZHA
GNU General Public License v3.0
145 stars 40 forks source link

Implement ZDO converters for `NWK_addr_req` and `IEEE_addr_req` #122

Closed puddly closed 2 years ago

puddly commented 2 years ago

Fixes https://github.com/zigpy/zigpy-znp/issues/121

This change passes all request keyword arguments to ZDO converters since the destination address alone is not always enough to capture the response.

Will become unnecessary when https://github.com/zigpy/zigpy-znp/pull/109 is merged.

codecov-commenter commented 2 years ago

Codecov Report

Merging #122 (f4c2aa7) into dev (48438ca) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #122      +/-   ##
==========================================
- Coverage   98.81%   98.76%   -0.06%     
==========================================
  Files          44       44              
  Lines        3880     3881       +1     
==========================================
- Hits         3834     3833       -1     
- Misses         46       48       +2
Impacted Files Coverage Δ
zigpy_znp/zigbee/zdo_converters.py 100.00% <ø> (ø)
zigpy_znp/commands/zdo.py 100.00% <100.00%> (ø)
zigpy_znp/utils.py 100.00% <100.00%> (ø)
zigpy_znp/zigbee/application.py 96.60% <100.00%> (-0.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48438ca...f4c2aa7. Read the comment docs.