zigpy / zigpy-znp

TI CC2531, CC13x2, CC26x2 radio support for Zigpy and ZHA
GNU General Public License v3.0
149 stars 40 forks source link

Subscribe to all ZDO cluster callbacks at once #178

Closed puddly closed 2 years ago

puddly commented 2 years ago

As opposed to subscribing to all ZDO responses individually, subscribe to them all with 0xFFFF and filter out the unnecessary ones in software.

This should reduce runtime memory usage.

codecov-commenter commented 2 years ago

Codecov Report

Base: 98.60% // Head: 98.55% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (6930ccd) compared to base (824c2b2). Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #178 +/- ## ========================================== - Coverage 98.60% 98.55% -0.06% ========================================== Files 43 43 Lines 3865 3869 +4 ========================================== + Hits 3811 3813 +2 - Misses 54 56 +2 ``` | [Impacted Files](https://codecov.io/gh/zigpy/zigpy-znp/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [zigpy\_znp/zigbee/application.py](https://codecov.io/gh/zigpy/zigpy-znp/pull/178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-emlncHlfem5wL3ppZ2JlZS9hcHBsaWNhdGlvbi5weQ==) | `94.86% <50.00%> (-0.63%)` | :arrow_down: | | [zigpy\_znp/api.py](https://codecov.io/gh/zigpy/zigpy-znp/pull/178/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-emlncHlfem5wL2FwaS5weQ==) | `97.15% <0.00%> (+0.23%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.