codecov-commenter
commented
2 years ago Codecov Report
Base: 98.50% // Head: 98.50% // No change to project coverage :thumbsup:
Coverage data is based on head (
3b896cc) compared to base (ca061f4). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #183 +/- ## ======================================= Coverage 98.50% 98.50% ======================================= Files 43 43 Lines 3806 3806 ======================================= Hits 3749 3749 Misses 57 57 ``` | [Impacted Files](https://codecov.io/gh/zigpy/zigpy-znp/pull/183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy) | Coverage Δ | | |---|---|---| | [zigpy\_znp/api.py](https://codecov.io/gh/zigpy/zigpy-znp/pull/183/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy#diff-emlncHlfem5wL2FwaS5weQ==) | `96.69% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zigpy):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The network formation timemout was not passed down to request, which meant it was cancelled with the default AREQ timeout. Network formation can also take longer than 30s in a noisy environment which is why I increased it to 60. If the request is cancelled and zigpy restarts. The following Ping seems to crash the controller if the formation has not completed in the mean time.